fix(primeng/p-password): incorrect class assignment for true value of toggleMask in the password component.
#11416
+42
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of `toggleMask` in the password component. The problem appeared during fix of the bug primefaces#10716 (running `detectChanges` in `pInputText`). Setter has been ran by detector without running doCheck inside `ngClass`. Fixes primefaces#11356, primefaces#11408.
volvachev
force-pushed
the
fix-password-input-not-valid-class-render
branch
from
33bd4f0 to
12f6a81
Compare
cetincakiroglu
added
the
Status: Pending Review
|
Thanks @volvachev Please, I need this fix <3 |
|
Thanks a lot for your contribution, @volvachev ;) |
mertsincan
removed
the
Status: Pending Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem appeared during fix of the bug #10716 (running
detectChangesinpInputText). Setter has been ran by detector without runningdoCheckinsidengClass.To avoid the problem, either do not run
detectChangesinsidepInputTextor do not use methods inside the template, for example: replace them withpipes, or call thedetectChangesmethod insidengAfterViewInit(p-password) as well.To solve the problem, I have decided to use
pipesbecause this is the best solution from my point of view.But if you want to replace the
detectChangescall, I will do itDefect Fixes
#11356, #11408.